Fixes: Language Change Applied Without Confirmation in Modal #634
+39
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ordered the translation keys same as en.js file to check the difference easily - improve word selection and sentence structure Issue: drawdb-io#627
|
@akib22 is attempting to deploy a commit to the dottle's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @1ilit, I hope you're doing well. Could you please review this PR when you have a moment? I apologize for mistakenly creating this PR on the fork's It would be a great help if you could merge this PR so I can continue working without any hassle. I really appreciate your time and support. Thank you so much! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1ilit
approved these changes
Oct 11, 2025
ewqazxc
pushed a commit
to ewqazxc/drawdb
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a bug where the UI language changes immediately upon selecting a language from the modal, even if the user does not click the "Confirm" button. Previously, closing or canceling the modal would still apply the selected language, which was unexpected behavior.
With this fix, the UI only applies the new language when the user explicitly confirms their choice. If the modal is closed or canceled, the language remains unchanged.
Changes Made
Video
fix-drawdb-language-selection.mov
Related Issue
Closes #632
Checklist
#hacktoberfest